Removing star import and adding errorprone rule #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfakbar20
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
gfakbar20
requested review from
HonahX,
MonkeyCanCode,
ajantha-bhat,
ebyhr,
flyrain,
pingtimeout and
singhpk234
as code owners
flyrain
reviewed
Jun 7, 2025
dimas-b
reviewed
Jun 9, 2025
...ark/v3.5/spark/src/main/java/org/apache/polaris/spark/rest/LoadGenericTableRestResponse.java
Outdated
Show resolved
Hide resolved
dimas-b
reviewed
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Thanks for you contribution, @gfakbar20 !
The detection of star imports (as declared in the PR title) is very useful, IMHO.
However, this PR brings many more checks, including those that require renaming existing stuff... I believe those kinds of changes need to be discussed on the dev ML.
If you prefer to scope this PR down to just enforcing star imports, it would be much simpler to approve and merge :)
snazy
reviewed
Jun 10, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Why not add the corresponding errorprone rule?
Contributor
Agreed with @snazy, it would be a matter of just adding this snippet to |
Contributor
|
+1 to enforcing this in ErrorProne |
Contributor
Author
|
i will fix it tonight |
gfakbar20
force-pushed
the
add_checkstyle
branch
from
01ecb0e to
f747207
Compare
gfakbar20
changed the title
snazy
reviewed
Jun 11, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Looks good to me.
Mind reverting the unrelated changes?
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* main: Update dependency io.projectreactor.netty:reactor-netty-http to v1.2.7 (apache#1845) * docs: fix broken 'Polaris Overview' link in README.md (apache#1846) docs: fix broken 'Polaris Overview' link in README.md Co-authored-by: Joy Haldar <Joy.Haldar@target.com> * Update spark client license (apache#1839) * Update LICENCE (apache#1851) * Add Yun Zou as the new committer Co-authored-by: Yufei Gu <yufei.apache.org> * main: Update docker.io/jaegertracing/all-in-one Docker tag to v1.70.0 (apache#1853) * main: Update dependency io.opentelemetry.semconv:opentelemetry-semconv to v1.34.0 (apache#1850) * main: Update dependency boto3 to v1.38.34 (apache#1852) * main: Update dependency org.postgresql:postgresql to v42.7.7 (apache#1859) * [SPEC] Add base-location keyword for GenericTable API (apache#1543) * Update LICENSE for binary distributions (apache#1855) * Add integration tests to Python Client (apache#1856) * Update JDBC Getting-started example's README.md to use localhost for curl commands (apache#1872) * Remove PolarisConfiguration.loadConfig (v2) (apache#1858) * Enhance EclipseLink quickstart (apache#1870) 1. Update the name catalog name used to `quickstart_catalog` from `polaris` to make it consistent 2. Update the name of `eclipselink-trino-1` to `polaris-trino-1` 3. make the polaris server url consistent with using `localhost` to avoid failures * Remove generated Python client from git tracking (apache#1810) After apache#1675, we now generate the Python client on-demand when it's needed by tests or the CLI. With this, we can safely remove the Python client from being tracked in the repo and add its files to .gitignore * Fix telemetry quickstart example for 1.0 release (apache#1873) * main: Update gradle/actions digest to ac638b0 (apache#1877) * main: Update dependency boto3 to v1.38.35 (apache#1874) * Removing star import and adding errorprone rule (apache#1831) Fixes apache#1100 * NoSQL: merge related changes * Last merged commit 0faf948 --------- Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Joy Haldar <joyno.23@gmail.com> Co-authored-by: Joy Haldar <Joy.Haldar@target.com> Co-authored-by: gh-yzou <167037035+gh-yzou@users.noreply.github.com> Co-authored-by: Yufei Gu <yufei@apache.org> Co-authored-by: Yun Zou <yunzou.colostate@gmail.com> Co-authored-by: Honah (Jonas) J. <honahx@apache.org> Co-authored-by: Eric Maynard <eric.maynard+oss@snowflake.com> Co-authored-by: William Hyun <william@apache.org> Co-authored-by: gfakbar20 <gfakbar20@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is made to solve #1100, based on #@snazy suggestion.
Thanks!